Issue 9383005: Add method skeleton for showing website settings. Add commandline flag.

Issue 9383005: Add method skeleton for showing website settings. Add commandline flag. (Closed)

Created:
8 years, 10 months ago by markusheintz_

Modified:
8 years, 10 months ago

Reviewers:
jennb, Elliot Glaysher, Ben Goodger (Google), Scott Hess - ex-Googler, prasadt

CC:
chromium-reviews, piman+watch_chromium.org, Avi (use Gerrit), jennb, creis+watch_chromium.org, ben+watch_chromium.org, Ian Vollick, dhollowa+watch_chromium.org, jonathan.backer, ajwong+watch_chromium.org, jam, Dmitry Titov, jianli, prasadt, joi+watch-content_chromium.org, darin-cc_chromium.org, dcheng, brettw-cc_chromium.org, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add method skeleton for showing website settings. Add command line flag for enabling website settings. This is the first CL of a series of CL for add website settings. Next CLs are: https://chromiumcodereview.appspot.com/9378014 (WIP) https://chromiumcodereview.appspot.com/9379016/ BUG=113688 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122740

Patch Set 1 #

Patch Set 2 : Remove unrelated changes. #

Patch Set 3 : Make unit_tests build #

Patch Set 4 : Rebase on tot #

Patch Set 5 : Rebase on tot #

Patch Set 6 : Fix mac and windows build after rebasing on tot #

Patch Set 7 : Fix copyright in file headers #

Total comments: 2

Patch Set 8 : Fix typo in comment. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -10 lines)			Patch
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1 2 3 4	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View	1 2 3 4 5	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 2 3 4	1 chunk	+13 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_window.h	View	1 2 3 4 5 6 7	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.mm	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm	View	1 2 3 4 5 6	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.h	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel.h	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/panels/panel.cc	View	1 2 3 4	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2 3 4	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/click_handler.cc	View	1 2 3 4 5 6	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/base/test_browser_window.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

markusheintz_

@Ben: Could you please review the ui related parts of this CL? @Avi: Could you ...

8 years, 10 months ago (2012-02-10 19:26:04 UTC) #1

markusheintz_

Thanks a lot for the review Ben. @Avi: After rebasing on tot the CL does ...

8 years, 10 months ago (2012-02-16 23:34:15 UTC) #3

markusheintz_

Adding more OWNERS for reviewing this CL. Dear $1 could you please review: shess: chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm ...

8 years, 10 months ago (2012-02-17 14:01:37 UTC) #4

jennb

LGTM for chrome/browser/ui/panels http://codereview.chromium.org/9383005/diff/14023/chrome/browser/ui/browser_window.h File chrome/browser/ui/browser_window.h (right): http://codereview.chromium.org/9383005/diff/14023/chrome/browser/ui/browser_window.h#newcode289 chrome/browser/ui/browser_window.h:289: // Shows the website settings using ...

8 years, 10 months ago (2012-02-17 18:13:45 UTC) #5

markusheintz_

8 years, 10 months ago (2012-02-20 10:18:06 UTC) #8

Thanks for reviewing.

http://codereview.chromium.org/9383005/diff/14023/chrome/browser/ui/browser_w...
File chrome/browser/ui/browser_window.h (right):

http://codereview.chromium.org/9383005/diff/14023/chrome/browser/ui/browser_w...
chrome/browser/ui/browser_window.h:289: // Shows the website settings using the
specified informatin. |url| is the url
On 2012/02/17 18:13:45, jennb wrote:
> informatin

Done.

Expand Messages | Collapse Messages