Issue 9383003: MIPS: Count-based profiling for primitive functions (hidden behind a flag)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9383003: MIPS: Count-based profiling for primitive functions (hidden behind a flag) (Closed)

Created:
8 years, 10 months ago by kalmard

Modified:
8 years, 10 months ago

Reviewers:
kisg, Paul Lind, danno, Jakob Kummerow

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Count-based profiling for primitive functions (hidden behind a flag) Port r10657 (92073cf). BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10677

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -1 line)			Patch
	M	src/mips/full-codegen-mips.cc	View		2 chunks	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 10 months ago (2012-02-10 14:56:02 UTC) #2

LGTM. I'll land this.

Please be aware that my current work on the profiler is highly experimental. I
fully expect it to morph significantly before it reaches its final shape, which
is why I'm implementing some of it only for ia32 for now (but some ARM ports
will follow in due course to allow for testing on Android devices). It's fine by
me if you port all changes as they are landed, but if you want to minimize
overall effort, you might want to hold off a little while until things settle
down.

The above statement is true for all CLs that have to do with the section titled
"// Experimental profiler changes." in flag-definitions.h.

Expand Messages | Collapse Messages