components/nacl/loader/nonsfi/nonsfi_sandbox.cc - Issue 938223004: Linux sandbox: better APIs with /proc/ arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nonsfi/nonsfi_sandbox.cc

Issue 938223004: Linux sandbox: better APIs with /proc/ arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix invalid proc_fd_ usage. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/loader/nonsfi/nonsfi_sandbox.cc

diff --git a/components/nacl/loader/nonsfi/nonsfi_sandbox.cc b/components/nacl/loader/nonsfi/nonsfi_sandbox.cc

index ea32abeebd928dc622e0f654bfa3cb9e81961bd4..0340f6ff146c60669a1e4addea6570555b62da25 100644

--- a/components/nacl/loader/nonsfi/nonsfi_sandbox.cc

+++ b/components/nacl/loader/nonsfi/nonsfi_sandbox.cc

@@ -300,11 +300,11 @@ ResultExpr NaClNonSfiBPFSandboxPolicy::InvalidSyscall() const {

return CrashSIGSYS();

}

-bool InitializeBPFSandbox(base::ScopedFD proc_task_fd) {

+bool InitializeBPFSandbox(base::ScopedFD proc_fd) {

bool sandbox_is_initialized = content::InitializeSandbox(

scoped_ptr<sandbox::bpf_dsl::Policy>(

new nacl::nonsfi::NaClNonSfiBPFSandboxPolicy()),

- proc_task_fd.Pass());

+ proc_fd.Pass());

if (!sandbox_is_initialized)

return false;

RunSandboxSanityChecks();