chrome/browser/external_tab_container_win.h - Issue 9382037: Move ContextMenuParams struct from webkit/glue to content/public/common. The reasons are:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_tab_container_win.h

Issue 9382037: Move ContextMenuParams struct from webkit/glue to content/public/common. The reasons are: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix mac Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/platform_app_browsertest.cc ('k') | chrome/browser/external_tab_container_win.cc » ('j') | content/public/common/context_menu_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/external_tab_container_win.h

===================================================================

--- chrome/browser/external_tab_container_win.h (revision 121660)

+++ chrome/browser/external_tab_container_win.h (working copy)

@@ -150,7 +150,8 @@

virtual bool CanDownload(content::WebContents* source,

int request_id) OVERRIDE;

virtual bool OnGoToEntryOffset(int offset) OVERRIDE;

- virtual bool HandleContextMenu(const ContextMenuParams& params) OVERRIDE;

+ virtual bool HandleContextMenu(

+ const content::ContextMenuParams& params) OVERRIDE;

virtual bool ExecuteContextMenuCommand(int command) OVERRIDE;

virtual void BeforeUnloadFired(content::WebContents* tab,

bool proceed,

@@ -402,7 +403,7 @@

return false;

}

- virtual bool HandleContextMenu(const ContextMenuParams& params) {

+ virtual bool HandleContextMenu(const content::ContextMenuParams& params) {

NOTREACHED();

return false;

}