chrome/browser/extensions/extension_context_menu_browsertest.cc - Issue 9382037: Move ContextMenuParams struct from webkit/glue to content/public/common. The reasons are:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_context_menu_browsertest.cc

Issue 9382037: Move ContextMenuParams struct from webkit/glue to content/public/common. The reasons are: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix mac Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/extensions/extension_menu_manager.h » ('j') | content/public/common/context_menu_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_context_menu_browsertest.cc

===================================================================

--- chrome/browser/extensions/extension_context_menu_browsertest.cc (revision 121660)

+++ chrome/browser/extensions/extension_context_menu_browsertest.cc (working copy)

@@ -12,10 +12,10 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/test/base/ui_test_utils.h"

+#include "content/public/common/context_menu_params.h"

#include "net/base/mock_host_resolver.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebContextMenuData.h"

#include "ui/base/models/menu_model.h"

-#include "webkit/glue/context_menu.h"

using WebKit::WebContextMenuData;

using content::WebContents;

@@ -28,7 +28,7 @@

class TestRenderViewContextMenu : public RenderViewContextMenu {

public:

TestRenderViewContextMenu(WebContents* web_contents,

- const ContextMenuParams& params)

+ const content::ContextMenuParams& params)

: RenderViewContextMenu(web_contents, params) {}

virtual ~TestRenderViewContextMenu() {}

@@ -138,7 +138,7 @@

const GURL& frame_url) {

WebContents* web_contents = browser->GetSelectedWebContents();

WebContextMenuData data;

- ContextMenuParams params(data);

+ content::ContextMenuParams params(data);

params.page_url = page_url;

params.link_url = link_url;

params.frame_url = frame_url;