Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9382037: Move ContextMenuParams struct from webkit/glue to content/public/common. The reasons are: (Closed)

Created:
8 years, 10 months ago by jam
Modified:
8 years, 10 months ago
CC:
chromium-reviews, robertshield, Avi (use Gerrit), creis+watch_chromium.org, nkostylev+watch_chromium.org, rdsmith+dwatch_chromium.org, kkania, ajwong+watch_chromium.org, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, pam+watch_chromium.org, yoshiki+watch_chromium.org, brettw-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move ContextMenuParams struct from webkit/glue to content/public/common. The reasons are: -this struct wasn't used at all in webkit layer, so no need to have it there -we can avoid exposing content layer's serialization of SSLInfo to embedders -avoid mentioning routing_ids in the webkit layer BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121673

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : readd testshell_test as browsertest #

Patch Set 5 : fix mac #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -728 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/choose_mobile_network_dialog.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/choose_mobile_network_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_html_dialog.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_html_dialog.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/web_page_screen.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/web_page_screen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/sim_dialog_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/sim_dialog_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_menu_manager.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_menu_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_menu_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_webnavigation_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/external_tab_container_win.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/page_info_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud_internal.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/chrome_tab_contents_view_wrapper_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/chrome_tab_contents_view_wrapper_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/chrome_web_contents_view_mac_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/chrome_web_contents_view_mac_delegate.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 6 chunks +7 lines, -23 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_observer.h View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_observer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_unittest.cc View 16 chunks +22 lines, -25 lines 0 comments Download
M chrome/browser/tab_contents/spellchecker_submenu_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/page_info_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/page_info_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/html_dialog_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/html_dialog_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/page_info_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/html_dialog_ui.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/html_dialog_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_dialog.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_dialog.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/task_manager_dialog.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/automation_messages.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.h View 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M content/browser/ssl/ssl_manager.h View 1 chunk +0 lines, -12 lines 0 comments Download
M content/browser/ssl/ssl_manager.cc View 3 chunks +7 lines, -45 lines 0 comments Download
M content/browser/ssl/ssl_policy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/tab_contents/interstitial_page_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/navigation_entry_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/navigation_entry_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/provisional_load_details.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_gtk.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_view_wrapper_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/web_contents_view_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/web_contents_view_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
A content/common/ssl_status_serialization.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A content/common/ssl_status_serialization.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 7 chunks +48 lines, -39 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_common.gypi View 3 chunks +6 lines, -0 lines 0 comments Download
M content/public/browser/render_view_host_delegate.h View 3 chunks +2 lines, -2 lines 0 comments Download
D content/public/browser/ssl_status.h View 1 chunk +0 lines, -55 lines 0 comments Download
D content/public/browser/ssl_status.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/web_contents_view_mac_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
A content/public/common/DEPS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits.h View 2 chunks +6 lines, -0 lines 0 comments Download
A + content/public/common/context_menu_params.h View 1 2 3 4 3 chunks +20 lines, -20 lines 2 comments Download
A + content/public/common/context_menu_params.cc View 1 2 3 4 5 chunks +17 lines, -7 lines 0 comments Download
A + content/public/common/ssl_status.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/public/common/ssl_status.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.h View 3 chunks +3 lines, -6 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 5 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 2 chunks +25 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 4 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 5 chunks +4 lines, -4 lines 0 comments Download
M content/test/render_view_test.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/render_view_test.cc View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M content/test/test_web_contents_view.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/test_web_contents_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
D webkit/glue/context_menu.h View 1 chunk +0 lines, -141 lines 0 comments Download
D webkit/glue/context_menu.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D webkit/glue/context_menu_unittest.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 3 chunks +0 lines, -9 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 10 months ago (2012-02-12 03:25:40 UTC) #1
darin (slow to review)
LGTM http://codereview.chromium.org/9382037/diff/6181/content/public/common/context_menu_params.h File content/public/common/context_menu_params.h (right): http://codereview.chromium.org/9382037/diff/6181/content/public/common/context_menu_params.h#newcode22 content/public/common/context_menu_params.h:22: struct CustomContextMenuContext { why not put CONTENT_EXPORT on ...
8 years, 10 months ago (2012-02-12 20:02:56 UTC) #2
jam
8 years, 10 months ago (2012-02-12 20:41:00 UTC) #3 
http://codereview.chromium.org/9382037/diff/6181/content/public/common/contex...
File content/public/common/context_menu_params.h (right):

http://codereview.chromium.org/9382037/diff/6181/content/public/common/contex...
content/public/common/context_menu_params.h:22: struct CustomContextMenuContext
{
On 2012/02/12 20:02:56, darin wrote:
> why not put CONTENT_EXPORT on the struct as you do for ContextMenuParams?

I had just copied it without much thinking, Done.

Powered by Google App Engine
This is Rietveld 408576698