Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 9382036: Avoid generating an overriding field in dart:dom (Closed)

Created:
8 years, 10 months ago by sra1
Modified:
8 years, 10 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org, jimhug, kasperl
Visibility:
Public.

Description

Avoid generating an overriding field in dart:dom - Detect when the shadowed implementation is adequate and use that. - If it is not adequate, generate getter / setter BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4193

Patch Set 1 #

Patch Set 2 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -104 lines) Patch
M client/dom/frog/dom_frog.dart View 1 48 chunks +97 lines, -48 lines 0 comments Download
M client/dom/generated/src/frog/HTMLDocument.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/HTMLIsIndexElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/HTMLOptionsCollection.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGAElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGCircleElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGClipPathElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGDefsElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGDescElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGEllipseElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEBlendElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEColorMatrixElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEComponentTransferElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFECompositeElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEConvolveMatrixElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEDiffuseLightingElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEDisplacementMapElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEDropShadowElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEFloodElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEGaussianBlurElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEImageElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEMergeElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEMorphologyElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFEOffsetElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFESpecularLightingElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFETileElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFETurbulenceElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGFilterElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGForeignObjectElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGGElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGGlyphRefElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGGradientElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGImageElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGLineElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGMarkerElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGMaskElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGPathElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGPatternElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGPolygonElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGPolylineElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGRectElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGSVGElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGStopElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGSwitchElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGSymbolElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGTextContentElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGTitleElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/SVGUseElement.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/Uint8ClampedArray.dart View 1 chunk +2 lines, -1 line 0 comments Download
M client/dom/scripts/dartgenerator.py View 1 6 chunks +57 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
What I like about this change: - avoids the need to define the meaning of ...
8 years, 10 months ago (2012-02-12 18:01:18 UTC) #1
Jacob
8 years, 10 months ago (2012-02-13 19:11:00 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698