objects: fix template-related linker error

objects: fix template-related linker error


R=erik.corry@gmail.com
BUG=v8:1936
TEST=

Committed: https://code.google.com/p/v8/source/detail?r=10691

[danno, 2012-02-14 09:41:34]

LGTM. Landing.

[indutny, 2012-02-14 09:53:29]

On 2012/02/14 09:41:34, danno wrote:
> LGTM. Landing.

Can we backport it to 3.6.x?

[danno, 2012-02-14 10:58:12]

On 2012/02/14 09:53:29, indutny wrote:
> On 2012/02/14 09:41:34, danno wrote:
> > LGTM. Landing.
> 
> Can we backport it to 3.6.x?

Absolutely. I am waiting for our build bots to work through the revision to make
sure it compiles everywhere, then I will merge back 3.6-3.8.

[danno, 2012-02-14 12:06:15]

Is this the only symbol that needs to be defined for the backport? Erik added
about 20 new definitions for 3.8 for Seeded and Unseeded dictionaries, none of
these are in 3.6/3.7. Do any of these others cause failures because they are
missing?

On 2012/02/14 10:58:12, danno wrote:
> On 2012/02/14 09:53:29, indutny wrote:
> > On 2012/02/14 09:41:34, danno wrote:
> > > LGTM. Landing.
> > 
> > Can we backport it to 3.6.x?
> 
> Absolutely. I am waiting for our build bots to work through the revision to
make
> sure it compiles everywhere, then I will merge back 3.6-3.8.

[indutny, 2012-02-14 12:08:24]

The error I reported in issue was noticed on node.js v0.6.x which uses 3.6.
Sorry, but I can't tell you more about it.

On 2012/02/14 12:06:15, danno wrote:
> Is this the only symbol that needs to be defined for the backport? Erik added
> about 20 new definitions for 3.8 for Seeded and Unseeded dictionaries, none of
> these are in 3.6/3.7. Do any of these others cause failures because they are
> missing?
> 
> On 2012/02/14 10:58:12, danno wrote:
> > On 2012/02/14 09:53:29, indutny wrote:
> > > On 2012/02/14 09:41:34, danno wrote:
> > > > LGTM. Landing.
> > > 
> > > Can we backport it to 3.6.x?
> > 
> > Absolutely. I am waiting for our build bots to work through the revision to
> make
> > sure it compiles everywhere, then I will merge back 3.6-3.8.

[danno, 2012-02-14 12:19:16]

Unfortunately, versions previous to 3.8 do not have the seeded/unseeded number
dictionaries at all, so adding this definition causes a compilation error. I
can't see how this patch could help fix any problem in a 3.6 build (perhaps 3.8
was meant instead?), and the bug doesn't provide much clarification. In any
case, the fix is now in bleeding_edge and merged back to 3.8, and will be in
trunk with our next push.  

On 2012/02/14 12:08:24, indutny wrote:
> The error I reported in issue was noticed on node.js v0.6.x which uses 3.6.
> Sorry, but I can't tell you more about it.
> 
> On 2012/02/14 12:06:15, danno wrote:
> > Is this the only symbol that needs to be defined for the backport? Erik
added
> > about 20 new definitions for 3.8 for Seeded and Unseeded dictionaries, none
of
> > these are in 3.6/3.7. Do any of these others cause failures because they are
> > missing?
> > 
> > On 2012/02/14 10:58:12, danno wrote:
> > > On 2012/02/14 09:53:29, indutny wrote:
> > > > On 2012/02/14 09:41:34, danno wrote:
> > > > > LGTM. Landing.
> > > > 
> > > > Can we backport it to 3.6.x?
> > > 
> > > Absolutely. I am waiting for our build bots to work through the revision
to
> > make
> > > sure it compiles everywhere, then I will merge back 3.6-3.8.

[indutny, 2012-02-14 12:19:46]

Ok, Thank you anyway!