Issue 9382032: [uber page] Migrate the change picture sub-page to a dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9382032: [uber page] Migrate the change picture sub-page to a dialog (Closed)

Created:
8 years, 10 months ago by Dan Beam

Modified:
8 years, 10 months ago

Reviewers:
csilv, James Hawkins, Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[uber page] Migrate the change picture sub-page to a dialog TEST=Change picture page still looks good and the code makes sense. BUG=111691 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121654

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -8 lines)			Patch
M	chrome/browser/resources/options2/chromeos/change_picture_options.html	View		1 chunk	+10 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options2/chromeos/change_picture_options.js	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options2/options.html	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options2/options.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Dan Beam

anybody that wants this can review, seems like a pretty trivial change (though that's what ...

8 years, 10 months ago (2012-02-11 04:13:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/9382032/2001

8 years, 10 months ago (2012-02-11 19:12:41 UTC) #3

Change committed as 121654