Issue 9382005: MIPS: Fixed several bugs in SubStringStub::Generate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9382005: MIPS: Fixed several bugs in SubStringStub::Generate. (Closed)

Created:
8 years, 10 months ago by kalmard

Modified:
8 years, 10 months ago

Reviewers:
kisg, Paul Lind, danno

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Fixed several bugs in SubStringStub::Generate. A combination of bugs caused this function to almost always jump to runtime which is why most tests passed. BUG= TEST=sputnik/S15.5.4.13_A2_T6 Committed: https://code.google.com/p/v8/source/detail?r=10678

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -9 lines)			Patch
	M	src/mips/code-stubs-mips.cc	View		1 chunk	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2012/02/10 14:43:10, kalmard wrote:

LGTM, landing.

Expand Messages | Collapse Messages