Provide user-friendly access to natively bound function parameters

Provide user-friendly access to natively bound function parameters

For a closure created using native Function.prototype.bind() the most important information for the heap profiler user is bound function, receiver and arguments. This change adds shortcuts for those fields.
Committed: https://code.google.com/p/v8/source/detail?r=10675

[yurys, 2012-02-10 11:30:13]

http://codereview.chromium.org/9382002/diff/3001/src/profile-generator.cc
File src/profile-generator.cc (left):

http://codereview.chromium.org/9382002/diff/3001/src/profile-generator.cc#old...
src/profile-generator.cc:2129: } else if (obj->IsDescriptorArray()) {
DescriptorArray is indistinguishable from a regular FixedArray, so this check is
wrong, I'm removing this special case.

[mnaganov (inactive), 2012-02-10 12:28:20]

LGTM with comments

http://codereview.chromium.org/9382002/diff/3001/src/profile-generator.cc
File src/profile-generator.cc (left):

http://codereview.chromium.org/9382002/diff/3001/src/profile-generator.cc#old...
src/profile-generator.cc:2129: } else if (obj->IsDescriptorArray()) {
On 2012/02/10 11:30:14, Yury Semikhatsky wrote:
> DescriptorArray is indistinguishable from a regular FixedArray, so this check
is
> wrong, I'm removing this special case.

OK, thanks!

http://codereview.chromium.org/9382002/diff/3001/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/9382002/diff/3001/src/profile-generator.cc#new...
src/profile-generator.cc:2172: SetNativeBindReference(js_obj, entry, "bound
this",
Perhaps, use underscores for names? Otherwise it might look confusing when
showing retaining paths. Have you checked that?

http://codereview.chromium.org/9382002/diff/3001/src/profile-generator.cc#new...
src/profile-generator.cc:2178: SetNativeBindReference(js_obj, entry, "bound
argument",
Does it make sense to label them "bound_argument_%d"?

[yurys, 2012-02-10 13:48:58]

http://codereview.chromium.org/9382002/diff/3001/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/9382002/diff/3001/src/profile-generator.cc#new...
src/profile-generator.cc:2172: SetNativeBindReference(js_obj, entry, "bound
this",
On 2012/02/10 12:28:21, Mikhail Naganov (Chromium) wrote:
> Perhaps, use underscores for names? Otherwise it might look confusing when
> showing retaining paths. Have you checked that?

Makes sense. Done.

http://codereview.chromium.org/9382002/diff/3001/src/profile-generator.cc#new...
src/profile-generator.cc:2178: SetNativeBindReference(js_obj, entry, "bound
argument",
On 2012/02/10 12:28:21, Mikhail Naganov (Chromium) wrote:
> Does it make sense to label them "bound_argument_%d"?

Done.