Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: client/dom/scripts/dartgenerator.py

Issue 9381030: Let EventTarget be a base class in the frog dom. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: EventsTest passes Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/generated/src/frog/XMLHttpRequestUpload.dart ('k') | client/tests/client/client.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/scripts/dartgenerator.py
diff --git a/client/dom/scripts/dartgenerator.py b/client/dom/scripts/dartgenerator.py
index f3fa63207b600b50ac7f276529dcd29e2260722f..1170444b0eca3ee6dd0dd1f2f822db9a3515c7ca 100755
--- a/client/dom/scripts/dartgenerator.py
+++ b/client/dom/scripts/dartgenerator.py
@@ -1988,24 +1988,9 @@ class FrogInterfaceGenerator(object):
base = None
if interface.parents:
supertype = interface.parents[0].type.id
- # FIXME: We're currently injecting List<..> and EventTarget as
- # supertypes in dart.idl. We should annotate/preserve as
- # attributes instead. For now, this hack lets the interfaces
- # inherit, but not the classes.
- if (not _IsDartListType(supertype) and
- not supertype == 'EventTarget'):
- base = self._ImplClassName(supertype)
if _IsDartCollectionType(supertype):
# List methods are injected in AddIndexer.
pass
- elif supertype == 'EventTarget':
- # Most implementors of EventTarget specify the EventListener operations
- # again. If the operations are not specified, try to inherit from the
- # EventTarget implementation.
- #
- # Applies to MessagePort.
- if not [op for op in interface.operations if op.id == 'addEventListener']:
- base = self._ImplClassName(supertype)
else:
base = self._ImplClassName(supertype)
« no previous file with comments | « client/dom/generated/src/frog/XMLHttpRequestUpload.dart ('k') | client/tests/client/client.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698