Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: chrome/browser/autofill/autofill_external_delegate.h

Issue 9380051: Coverity: Fix a few pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_ 6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
7 #pragma once 7 #pragma once
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 const std::vector<string16>& autofill_values, 55 const std::vector<string16>& autofill_values,
56 const std::vector<string16>& autofill_labels, 56 const std::vector<string16>& autofill_labels,
57 const std::vector<string16>& autofill_icons, 57 const std::vector<string16>& autofill_icons,
58 const std::vector<int>& autofill_unique_ids); 58 const std::vector<int>& autofill_unique_ids);
59 59
60 // Inform the delegate that the text field editing has ended, this is 60 // Inform the delegate that the text field editing has ended, this is
61 // used to help record the metrics of when a new popup is shown. 61 // used to help record the metrics of when a new popup is shown.
62 void DidEndTextFieldEditing(); 62 void DidEndTextFieldEditing();
63 63
64 // Inform the delegate that an autofill suggestion have been chosen. 64 // Inform the delegate that an autofill suggestion have been chosen.
65 void DidAcceptAutofillSuggestions(string16 value, 65 void DidAcceptAutofillSuggestions(const string16& value,
66 int unique_id, 66 int unique_id,
67 unsigned index); 67 unsigned index);
68 68
69 // Informs the delegate that the Autofill previewed form should be cleared. 69 // Informs the delegate that the Autofill previewed form should be cleared.
70 virtual void ClearPreviewedForm(); 70 virtual void ClearPreviewedForm();
71 71
72 // Hide the Autofill poup. 72 // Hide the Autofill poup.
73 virtual void HideAutofillPopup(); 73 virtual void HideAutofillPopup();
74 74
75 // Platforms that wish to implement an external Autofill delegate 75 // Platforms that wish to implement an external Autofill delegate
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 // The menu index of the "Clear" menu item. 129 // The menu index of the "Clear" menu item.
130 int suggestions_clear_index_; 130 int suggestions_clear_index_;
131 131
132 // The menu index of the "Autofill options..." menu item. 132 // The menu index of the "Autofill options..." menu item.
133 int suggestions_options_index_; 133 int suggestions_options_index_;
134 134
135 DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate); 135 DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
136 }; 136 };
137 137
138 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_ 138 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698