Issue 9380046: mac make&ninja: Support GCC_CHAR_IS_UNSIGNED_CHAR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9380046: mac make&ninja: Support GCC_CHAR_IS_UNSIGNED_CHAR. (Closed)

Created:
8 years, 10 months ago by Nico

Modified:
8 years, 10 months ago

Reviewers:
Mark Mentovai

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

mac make&ninja: Support GCC_CHAR_IS_UNSIGNED_CHAR. Used in breakpad. Apparently not critical, but if it's used, it should be supported. Committed: https://code.google.com/p/gyp/source/detail?r=1197

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	pylib/gyp/xcode_emulation.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

8 years, 10 months ago (2012-02-12 01:06:17 UTC) #2

LGTM. Some of the (maybe third-party?) DWARF handling code in Breakpad depends
on this, and breaks silently if char is signed.

Expand Messages | Collapse Messages