Add a stackframe named 'CrashIntentionally' to crashes from about:crash.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 307 matching lines @@
       params.navigation_type == ViewMsg_Navigate_Type::RELOAD_IGNORING_CACHE;
 }
 
 static WebReferrerPolicy getReferrerPolicyFromRequest(
     const WebURLRequest& request) {
   return request.extraData() ?
       static_cast<RequestExtraData*>(request.extraData())->referrer_policy() :
       WebKit::WebReferrerPolicyDefault;
 }
 
+// Disable optimizations so the symbol "CrashIntentionally()" does not get
+// optimized away. We want this name to appear in the crashed callstack to
+// make it clear what these crashes are about.
+#if defined(COMPILER_MSVC)
+#pragma optimize("", off)
+MSVC_PUSH_DISABLE_WARNING(4748)
+#endif
+
+#if defined(COMPILER_GCC)
+__attribute__((noinline))

[Nico, 2012/02/10 22:20:39]

Does this work? I thought attributes go behind the function, like so:

  static void CrashIntentionall() __attribute__((noinline))

+#endif
+
+static void CrashIntentionally() {
+  // NOTE(shess): Crash directly rather than using NOTREACHED() so
+  // that the signature is easier to triage in crash reports.
+  volatile int* zero = NULL;
+  *zero = 0;
+}
+
+#if defined(COMPILER_MSVC)
+MSVC_POP_WARNING()
+#pragma optimize("", on)
+#endif
+
 static void MaybeHandleDebugURL(const GURL& url) {
   if (!url.SchemeIs(chrome::kChromeUIScheme))
     return;
   if (url == GURL(chrome::kChromeUICrashURL)) {
-    // NOTE(shess): Crash directly rather than using NOTREACHED() so
-    // that the signature is easier to triage in crash reports.
-    volatile int* zero = NULL;
-    *zero = 0;
-
-    // Just in case the compiler decides the above is undefined and
-    // optimizes it away.
-    NOTREACHED();
+    CrashIntentionally();
   } else if (url == GURL(chrome::kChromeUIKillURL)) {
     base::KillProcess(base::GetCurrentProcessHandle(), 1, false);
   } else if (url == GURL(chrome::kChromeUIHangURL)) {
     for (;;) {
       base::PlatformThread::Sleep(base::TimeDelta::FromSeconds(1));
     }
   } else if (url == GURL(chrome::kChromeUIShorthangURL)) {
     base::PlatformThread::Sleep(base::TimeDelta::FromSeconds(20));
   }
 }
@@ skipping 4689 matching lines @@
 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const {
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit() {
   DCHECK(!java_bridge_dispatcher_.get());
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_.reset(new JavaBridgeDispatcher(this));
 #endif
 }