Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: dart/frog/leg/ssa/builder.dart

Issue 9380006: Support is!. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/frog/leg/ssa/builder.dart
===================================================================
--- dart/frog/leg/ssa/builder.dart (revision 4132)
+++ dart/frog/leg/ssa/builder.dart (working copy)
@@ -1220,7 +1220,19 @@
} else if (const SourceString("is") == op.source) {
visit(node.receiver);
HInstruction expression = pop();
- push(new HIs(elements[node.arguments.head], expression));
+ Node argument = node.arguments.head;
+ TypeAnnotation type = argument.asTypeAnnotation();
+ bool isNot = false;
+ if (type == null) {
+ type = argument.asSend().receiver;
ahe 2012/02/13 09:59:57 You're repeating the pattern from the resolver her
+ isNot = true;
+ }
+ HInstruction instruction = new HIs(elements[type], expression);
+ if (isNot) {
+ add(instruction);
+ instruction = new HNot(instruction);
+ }
+ push(instruction);
} else {
visit(node.receiver);
visit(node.argumentsNode);

Powered by Google App Engine
This is Rietveld 408576698