GTK: implement "print selection".

GTK: implement "print selection".

BUG=83481
TEST=mouse select text from http://en.wikipedia.org/wiki/Main_Page
Toolbox -> Print -> Print to File -> Selection -> Print, verify that PDF contains only selection.
Toolbox -> Print -> Print to File -> All Pages -> Print, verify that PDF contains all pages.
Toolbox -> Print -> Print to File -> Pages: 1 -> Print, verify that PDF contains only page 1.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121844

[Lei Zhang, 2012-02-13 22:41:17]

Thanks for making this patch. I have just one minor comment below.

Have you signed the Chromium CLA? Have you added yourself to src/AUTHORS?

https://chromiumcodereview.appspot.com/9379039/diff/1/chrome/browser/printing...
File chrome/browser/printing/print_dialog_gtk.cc (right):

https://chromiumcodereview.appspot.com/9379039/diff/1/chrome/browser/printing...
chrome/browser/printing/print_dialog_gtk.cc:353: default:
Would you mind changing this to:

case GTK_PRINT_PAGES_ALL:
  // Leave |ranges_vector| empty to indicate print all pages.
  break;
case GTK_PRINT_PAGES_CURRENT:
default:
  NOTREACHED();
  break;

[peter1, 2012-02-14 01:52:44]

On 2012/02/13 22:41:17, Lei Zhang wrote:
> Have you signed the Chromium CLA?

Yes.

> Have you added yourself to src/AUTHORS?

I added myself to AUTHORS in another patch which is still under review:
https://chromiumcodereview.appspot.com/9232075/

I'm not sure what the policy is here.  Is it fine to just leave the hunk that
adds me to AUTHORS in the other patch?

[peter1, 2012-02-14 01:52:53]

https://chromiumcodereview.appspot.com/9379039/diff/1/chrome/browser/printing...
File chrome/browser/printing/print_dialog_gtk.cc (right):

https://chromiumcodereview.appspot.com/9379039/diff/1/chrome/browser/printing...
chrome/browser/printing/print_dialog_gtk.cc:353: default:
On 2012/02/13 22:41:17, Lei Zhang wrote:
> Would you mind changing this to:
> 
> case GTK_PRINT_PAGES_ALL:
>   // Leave |ranges_vector| empty to indicate print all pages.
>   break;
> case GTK_PRINT_PAGES_CURRENT:
> default:
>   NOTREACHED();
>   break;

Done.

[Lei Zhang, 2012-02-14 01:56:42]

I think you'll be able to check this CL in first, so why don't we add it here?

[peter1, 2012-02-14 02:06:08]

> I think you'll be able to check this CL in first, so why don't we add it here?

Done.

[Lei Zhang, 2012-02-14 02:14:49]

lgtm

[commit-bot: I haz the power, 2012-02-14 02:15:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peter@pcc.me.uk/9379039/2003

[Lei Zhang, 2012-02-14 02:15:31]

Go go commit-bot go!

Thanks again for doing this.

[commit-bot: I haz the power, 2012-02-14 03:58:07]

Change committed as 121844