Issue 9379033: Settings: Focus the password field of the cert restore dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9379033: Settings: Focus the password field of the cert restore dialog. (Closed)

Created:
8 years, 10 months ago by James Hawkins

Modified:
8 years, 10 months ago

Reviewers:
csilv, Dan Beam

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Settings: Focus the password field of the cert restore dialog. BUG=110192 TEST=none R=csilv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121614

Patch Set 2 : Style nit. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/resources/options2/certificate_restore_overlay.js	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

lgtm w/nit https://chromiumcodereview.appspot.com/9379033/diff/1/chrome/browser/resources/options2/certificate_restore_overlay.js File chrome/browser/resources/options2/certificate_restore_overlay.js (right): https://chromiumcodereview.appspot.com/9379033/diff/1/chrome/browser/resources/options2/certificate_restore_overlay.js#newcode42 chrome/browser/resources/options2/certificate_restore_overlay.js:42: * @inheritDoc nit: an overwhelming majority of ...

8 years, 10 months ago (2012-02-11 01:58:27 UTC) #2

James Hawkins

8 years, 10 months ago (2012-02-11 02:04:58 UTC) #3

https://chromiumcodereview.appspot.com/9379033/diff/1/chrome/browser/resource...
File chrome/browser/resources/options2/certificate_restore_overlay.js (right):

https://chromiumcodereview.appspot.com/9379033/diff/1/chrome/browser/resource...
chrome/browser/resources/options2/certificate_restore_overlay.js:42: *
@inheritDoc
On 2012/02/11 01:58:27, Dan Beam wrote:
> nit: an overwhelming majority of chrome/browser/resources uses /** @inheritDoc
> */ on one line (only a couple places in options doesn't).

Done.

Expand Messages | Collapse Messages

Issue 9379033: Settings: Focus the password field of the cert restore dialog. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Style nit. #

Messages