Chromium Code Reviews
Help | Chromium Project | Sign in
(455)

Issue 9379033: Settings: Focus the password field of the cert restore dialog. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by James Hawkins
Modified:
2 years, 2 months ago
Reviewers:
csilv, Dan Beam
CC:
chromium-reviews_chromium.org, arv
Visibility:
Public.

Description

Settings: Focus the password field of the cert restore dialog.

BUG=110192
TEST=none
R=csilv

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121614

Patch Set 1 #

Total comments: 2

Patch Set 2 : Style nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Lint Patch
M chrome/browser/resources/options2/certificate_restore_overlay.js View 1 2 chunks +6 lines, -2 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 3
James Hawkins
2 years, 2 months ago #1
Dan Beam
lgtm w/nit https://chromiumcodereview.appspot.com/9379033/diff/1/chrome/browser/resources/options2/certificate_restore_overlay.js File chrome/browser/resources/options2/certificate_restore_overlay.js (right): https://chromiumcodereview.appspot.com/9379033/diff/1/chrome/browser/resources/options2/certificate_restore_overlay.js#newcode42 chrome/browser/resources/options2/certificate_restore_overlay.js:42: * @inheritDoc nit: an overwhelming majority of ...
2 years, 2 months ago #2
James Hawkins
2 years, 2 months ago #3
https://chromiumcodereview.appspot.com/9379033/diff/1/chrome/browser/resource...
File chrome/browser/resources/options2/certificate_restore_overlay.js (right):

https://chromiumcodereview.appspot.com/9379033/diff/1/chrome/browser/resource...
chrome/browser/resources/options2/certificate_restore_overlay.js:42: *
@inheritDoc
On 2012/02/11 01:58:27, Dan Beam wrote:
> nit: an overwhelming majority of chrome/browser/resources uses /** @inheritDoc
> */ on one line (only a couple places in options doesn't).

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6