gclient_scm.py - Issue 9379005: [depot_tools] Use git fetch to optimize the properly configured that use git-svn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient_scm.py

Issue 9379005: [depot_tools] Use git fetch to optimize the properly configured that use git-svn (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: regex tweak Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gclient_scm.py

diff --git a/gclient_scm.py b/gclient_scm.py

index 211aa473792fa4d218c6ab8cddc09b96bc837a99..8df89563bb7e9a82f4941f8313a8ebdf00048270 100644

--- a/gclient_scm.py

+++ b/gclient_scm.py

@@ -500,6 +500,9 @@ class GitWrapper(SCMWrapper):

scm.GIT.IsGitSvn(cwd=self.checkout_path)):

local_head = scm.GIT.GetGitSvnHeadRev(cwd=self.checkout_path)

if not local_head or local_head < int(rev):

+ if scm.GIT.Capture(['config', '--get', 'svn-remote.svn.fetch'],

Dan Beam 2012/02/11 03:28:10 actually, should I be wrapping this in a try: exce

M-A Ruel 2012/02/14 22:06:20 Yes

+ cwd=self.checkout_path):

+ scm.GIT.Capture(['fetch'], cwd=self.checkout_path)

if options.verbose:

print('Running git svn fetch. This might take a while.\n')

scm.GIT.Capture(['svn', 'fetch'], cwd=self.checkout_path)

« no previous file with comments | « no previous file | presubmit_canned_checks.py » ('j') | presubmit_canned_checks.py » ('J')