Add website settings backend v 0.1

chrome/browser/website_settings.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_WEBSITE_SETTINGS_H_
+#define CHROME_BROWSER_WEBSITE_SETTINGS_H_
+
+#include "base/memory/scoped_ptr.h"

[Finnur, 2012/02/14 11:00:36]

You need this here?

[markusheintz_, 2012/02/14 13:36:55]

No that should have been moved to a different CL.

+#include "base/string16.h"
+
+#include "googleurl/src/gurl.h"
+
+namespace content {
+struct SSLStatus;
+}
+
+class Profile;
+class TabContentsWrapper;
+
+class WebsiteSettings {

[Finnur, 2012/02/14 11:00:36]

Isn't this a WebsiteSettingsModel class? Or did you intentionally leave out the
Model from the name?

[Finnur, 2012/02/14 11:00:36]

This class could do with some documentation (including members and functions)...

[markusheintz_, 2012/02/14 13:36:55]

I omitted the "Model" bc I think this will be more than just a data model in the
end. (But I guess that translates to: too lazy to rename). I added a Model
suffix I guess I can remove this once this really becomes a more heavy weight
obj.

[markusheintz_, 2012/02/14 13:36:55]

Done.

+ public:
+  enum SiteConnectionStatus {
+    SITE_CONNECTION_STATUS_NA = 0,
+    SITE_CONNECTION_STATUS_ENCRYPTED,           // OK
+    SITE_CONNECTION_STATUS_MIXED_CONTENT,       // Minor warning
+    SITE_CONNECTION_STATUS_UNENCRYPTED,         // Major warning
+    SITE_CONNECTION_STATUS_ENCRYPTED_ERROR,     // Error
+    SITE_CONNECTION_STATUS_INTERNAL_PAGE,       // Internal
+  };

[Finnur, 2012/02/14 11:00:36]

nit: end all comments with a period (here and below).

[markusheintz_, 2012/02/14 13:36:55]

Done.

+
+  enum SiteIdentityStatus {
+    SITE_IDENTITY_STATUS_NA = 0,
+    SITE_IDENTITY_STATUS_CERT,                  // OK
+    SITE_IDENTITY_STATUS_EV_CERT,               // OK
+    SITE_IDENTITY_STATUS_DNSSEC_CERT,           // OK
+    SITE_IDENTITY_STATUS_CERT_NOT_VERIFIED,     // Minor warning
+    SITE_IDENTITY_STATUS_NO_CERT,               // Major warning
+    SITE_IDENTITY_STATUS_ERROR,                 // Error
+    SITE_IDENTITY_STATUS_INTERNAL_PAGE,         // Internal
+  };
+
+  WebsiteSettings(Profile* profile,
+                  TabContentsWrapper* wrapper,
+                  const GURL& url,
+                  const content::SSLStatus& ssl,
+                  bool show_history);
+
+  virtual ~WebsiteSettings();
+
+  SiteConnectionStatus site_connection_status();
+
+  string16 site_connection_details();
+
+  SiteIdentityStatus site_identity_status();
+
+  string16 site_identity_details();

[Finnur, 2012/02/14 11:00:36]

All of these functions can have |const| at the end.

[markusheintz_, 2012/02/14 13:36:55]

Done.

+
+ private:
+  void Init(Profile* profile,
+            const GURL& url,
+            const content::SSLStatus& ssl);
+
+  SiteIdentityStatus site_identity_status_;
+
+  string16 organisation_name_;

[Finnur, 2012/02/14 11:00:36]

Spelling: According to what I've been reading, English spelling accepts both
organization and organisation but US spelling dictates the former
(organization).

[markusheintz_, 2012/02/14 13:36:55]

Changed to US version

+
+  string16 site_identity_details_;
+
+  SiteConnectionStatus site_connection_status_;

[Finnur, 2012/02/14 11:00:36]

nit: My personal preference would be to keep this next to SiteIdentityStatus?
Same with the accessors above.

[markusheintz_, 2012/02/14 13:36:55]

I sorted the fields and accessors like you suggested.

+
+  string16 site_connection_details_;
+
+  DISALLOW_COPY_AND_ASSIGN(WebsiteSettings);
+};
+
+#endif  // CHROME_BROWSER_WEBSITE_SETTINGS_H_