Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: frog/leg/resolver.dart

Issue 9378008: Support anonymous functions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/leg/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/leg/resolver.dart
diff --git a/frog/leg/resolver.dart b/frog/leg/resolver.dart
index b4b0367b165a6450f6c6d8336377e5949a94f383..8374287143700738375b6a63b6c9efee4733c43d 100644
--- a/frog/leg/resolver.dart
+++ b/frog/leg/resolver.dart
@@ -431,12 +431,15 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
return element;
}
- Element defineElement(Node node, Element element) {
+ Element defineElement(Node node, Element element,
+ [bool doAddToScope = true]) {
compiler.ensure(element !== null);
mapping[node] = element;
- Element existing = context.add(element);
- if (existing != element) {
- error(node, MessageKind.DUPLICATE_DEFINITION, [node]);
+ if (doAddToScope) {
+ Element existing = context.add(element);
+ if (existing != element) {
+ error(node, MessageKind.DUPLICATE_DEFINITION, [node]);
+ }
}
return element;
}
@@ -496,14 +499,16 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
visitFunctionExpression(FunctionExpression node) {
visit(node.returnType);
+ SourceString name;
if (node.name === null) {
- cancel(node, "anonymous functions are not implemented");
+ name = const SourceString("");
+ } else {
+ name = node.name.asIdentifier().source;
}
- SourceString name = node.name.asIdentifier().source;
FunctionElement enclosingElement = new FunctionElement.node(
name, node, ElementKind.FUNCTION, new Modifiers.empty(),
context.element);
- defineElement(node, enclosingElement);
+ defineElement(node, enclosingElement, doAddToScope: node.name !== null);
setupFunction(node, enclosingElement);
visit(node.body);
« no previous file with comments | « no previous file | frog/leg/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698