Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 9378005: MIPS: Implement KeyedStoreICs to grow arrays on out-of-bound stores. (Closed)

Created:
8 years, 10 months ago by kalmard
Modified:
8 years, 10 months ago
Reviewers:
kisg, Paul Lind, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Implement KeyedStoreICs to grow arrays on out-of-bound stores. Port r10673 (18d3af5). Original commit message: Supports growing non-COW JSArray by a single element if the backing store has room, and initial allocation of a backing store for the store to index zero of an empty array to kPreallocatedArrayElements elements (e.g. the [] array literal). BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10707

Patch Set 1 #

Patch Set 2 : Fixed debug test failures by adding a missing line. #

Patch Set 3 : rebased on r10702 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -36 lines) Patch
M src/mips/code-stubs-mips.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/mips/codegen-mips.cc View 7 chunks +41 lines, -15 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 9 chunks +172 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kalmard
8 years, 10 months ago (2012-02-10 14:47:01 UTC) #1
kalmard
rebased on r10702
8 years, 10 months ago (2012-02-14 15:14:33 UTC) #2
danno
8 years, 10 months ago (2012-02-14 15:48:07 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698