Issue 9375047: Heap Snapshot maximum size limit is too low for really big apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9375047: Heap Snapshot maximum size limit is too low for really big apps. (Closed)

Created:
8 years, 10 months ago by loislo

Modified:
8 years, 10 months ago

Reviewers:
mnaganov (inactive)

CC:
yurys

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Heap Snapshot maximum size limit is too low for really big apps. At the moment the limit is 256MB. BUG=113015 TEST=none

Patch Set 2 : adjusted a bit #

Patch Set 3 : the limit depends from the platform. #

Total comments: 2

Patch Set 4 : constant was moved to the suggested place. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	src/profile-generator.cc	View	1 2 3	3 chunks	+11 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

https://chromiumcodereview.appspot.com/9375047/diff/5001/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/9375047/diff/5001/src/profile-generator.cc#newcode3416 src/profile-generator.cc:3416: 768 * MB; I know a better place for ...

8 years, 10 months ago (2012-02-10 12:33:50 UTC) #2

lgtm