lib/code_generator.dart - Issue 93743006: Use package names as import prefixes when generating code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/code_generator.dart

Issue 93743006: Use package names as import prefixes when generating code (Closed) Base URL: https://github.com/dart-lang/dart-protoc-plugin.git@master

Patch Set: Addressed review commetns Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/code_generator.dart

diff --git a/lib/code_generator.dart b/lib/code_generator.dart

index 0e316a5225b999fa4764bad7749ab8f1905db786..1539ae483e43472dbe211863d6a8a0d128229074 100644

--- a/lib/code_generator.dart

+++ b/lib/code_generator.dart

@@ -5,8 +5,9 @@

part of protoc;

abstract class ProtobufContainer {

- String get fqname;

+ String get package;

String get classname;

+ String get fqname;

}

class CodeGenerator implements ProtobufContainer {

@@ -46,8 +47,9 @@ class CodeGenerator implements ProtobufContainer {

});

}

- String get fqname => '';

+ String get package => '';

String get classname => null;

+ String get fqname => '';

}

« no previous file with comments | « no previous file | lib/enum_generator.dart » ('j') | no next file with comments »