Issue 9374015: Split experimental profiler flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9374015: Split experimental profiler flags (Closed)

Created:
8 years, 10 months ago by Jakob Kummerow

Modified:
8 years, 10 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Split experimental profiler flags Committed: https://code.google.com/p/v8/source/detail?r=10660

Patch Set 2 : updated comment #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -13 lines)			Patch
M	src/compiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/flag-definitions.h	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/heap.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/runtime-profiler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime-profiler.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

As promised. Please take a look. More to come :-)

8 years, 10 months ago (2012-02-09 10:52:23 UTC) #1

Erik Corry

LGTM https://chromiumcodereview.appspot.com/9374015/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://chromiumcodereview.appspot.com/9374015/diff/1/src/flag-definitions.h#newcode168 src/flag-definitions.h:168: // Count-based optimization decisions. Comment needs updating.

8 years, 10 months ago (2012-02-09 11:13:01 UTC) #2