Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9538)

Unified Diff: chrome/common/extensions/extension_file_util_unittest.cc

Issue 9374009: Install platform apps into a separate data directory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase, address review comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_file_util_unittest.cc
diff --git a/chrome/common/extensions/extension_file_util_unittest.cc b/chrome/common/extensions/extension_file_util_unittest.cc
index 78fe617eb2ecc63e44b56355a0bdeb036f802d88..fb61d14b93fe9753a7e87274f59cc519a93a5cdf 100644
--- a/chrome/common/extensions/extension_file_util_unittest.cc
+++ b/chrome/common/extensions/extension_file_util_unittest.cc
@@ -38,10 +38,12 @@ TEST(ExtensionFileUtil, InstallUninstallGarbageCollect) {
ASSERT_TRUE(file_util::CreateDirectory(all_extensions));
// Install in empty directory. Should create parent directories as needed.
- FilePath version_1 = extension_file_util::InstallExtension(src,
- extension_id,
- version,
- all_extensions);
+ FilePath version_1 = extension_file_util::InstallExtension(
+ src,
+ extension_id,
+ version,
+ all_extensions,
+ /*should_delete=*/true);
ASSERT_EQ(version_1.value(),
all_extensions.AppendASCII(extension_id).AppendASCII("1.0_0")
.value());
@@ -52,10 +54,12 @@ TEST(ExtensionFileUtil, InstallUninstallGarbageCollect) {
// Install again. Should create a new one with different name.
ASSERT_TRUE(file_util::CreateDirectory(src));
- FilePath version_2 = extension_file_util::InstallExtension(src,
- extension_id,
- version,
- all_extensions);
+ FilePath version_2 = extension_file_util::InstallExtension(
+ src,
+ extension_id,
+ version,
+ all_extensions,
+ /*should_delete=*/true);
ASSERT_EQ(version_2.value(),
all_extensions.AppendASCII(extension_id).AppendASCII("1.0_1")
.value());

Powered by Google App Engine
This is Rietveld 408576698