Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4145)

Unified Diff: chrome/browser/web_applications/web_app_mac.mm

Issue 9374009: Install platform apps into a separate data directory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_applications/web_app_mac.mm
diff --git a/chrome/browser/web_applications/web_app_mac.mm b/chrome/browser/web_applications/web_app_mac.mm
index b0a7f1194e386c2bd7ee48837a1f181a37bab8f3..d37c843a8fb71a3205c3e25ff4cae05857df57d5 100644
--- a/chrome/browser/web_applications/web_app_mac.mm
+++ b/chrome/browser/web_applications/web_app_mac.mm
@@ -19,8 +19,9 @@
namespace web_app {
WebAppShortcutCreator::WebAppShortcutCreator(
+ const FilePath& web_app_path,
const ShellIntegration::ShortcutInfo& shortcut_info)
- : info_(shortcut_info) {
+ : web_app_path_(web_app_path), info_(shortcut_info) {
}
WebAppShortcutCreator::~WebAppShortcutCreator() {
@@ -101,6 +102,8 @@ bool WebAppShortcutCreator::UpdatePlist(const FilePath& app_path) const {
forKey:@"CFBundleName"];
[dict setObject:[base::mac::OuterBundle() bundleIdentifier]
forKey:app_mode::kBrowserBundleIDKey];
+ [dict setObject:base::mac::FilePathToNSString(web_app_path_)
+ forKey:app_mode::kCrAppModeUserDataDirKey];
Robert Sesek 2012/02/09 18:43:59 nit: align colons
sail 2012/02/10 00:13:18 Done.
return [dict writeToFile:plist_path atomically:NO];
}
@@ -114,7 +117,7 @@ namespace internals {
void CreateShortcutTask(const FilePath& web_app_path,
const FilePath& profile_path,
const ShellIntegration::ShortcutInfo& shortcut_info) {
- WebAppShortcutCreator shortcut_creator(shortcut_info);
+ WebAppShortcutCreator shortcut_creator(web_app_path, shortcut_info);
shortcut_creator.CreateShortcut();
}

Powered by Google App Engine
This is Rietveld 408576698