Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/browser/web_applications/web_app_mac_unittest.mm

Issue 9374009: Install platform apps into a separate data directory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_applications/web_app_mac_unittest.mm
diff --git a/chrome/browser/web_applications/web_app_mac_unittest.mm b/chrome/browser/web_applications/web_app_mac_unittest.mm
index f594f37217f864c0b2b46d247ffe2b5dea2f1f4e..d403346f828888128ee1d83d062a5e805e9fae85 100644
--- a/chrome/browser/web_applications/web_app_mac_unittest.mm
+++ b/chrome/browser/web_applications/web_app_mac_unittest.mm
@@ -23,8 +23,9 @@ namespace {
class WebAppShortcutCreatorMock : public web_app::WebAppShortcutCreator {
public:
explicit WebAppShortcutCreatorMock(
+ const FilePath& web_app_path,
const ShellIntegration::ShortcutInfo& shortcut_info)
- : WebAppShortcutCreator(shortcut_info) {
+ : WebAppShortcutCreator(web_app_path, shortcut_info) {
}
MOCK_CONST_METHOD1(GetDstPath, FilePath(const FilePath&));
@@ -45,7 +46,7 @@ TEST(WebAppShortcutCreatorTest, FAILS_CreateShortcut) {
FilePath dst_path = scoped_temp_dir.path().Append("a.app");
ShellIntegration::ShortcutInfo info = GetShortcutInfo();
- NiceMock<WebAppShortcutCreatorMock> shortcut_creator(info);
+ NiceMock<WebAppShortcutCreatorMock> shortcut_creator(FilePath(), info);
EXPECT_CALL(shortcut_creator, GetDstPath(_))
.WillRepeatedly(Return(dst_path));
EXPECT_TRUE(shortcut_creator.CreateShortcut());
@@ -67,7 +68,8 @@ TEST(WebAppShortcutCreatorTest, FAILS_CreateShortcut) {
}
TEST(WebAppShortcutCreatorTest, CreateFailure) {
- NiceMock<WebAppShortcutCreatorMock> shortcut_creator(GetShortcutInfo());
+ NiceMock<WebAppShortcutCreatorMock> shortcut_creator(
+ FilePath(), GetShortcutInfo());
EXPECT_CALL(shortcut_creator, GetDstPath(_))
.WillRepeatedly(Return(FilePath("/non-existant/path/")));
EXPECT_FALSE(shortcut_creator.CreateShortcut());

Powered by Google App Engine
This is Rietveld 408576698