Install platform apps into a separate data directory

chrome/common/extensions/extension_file_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_file_util.h"
 
 #include "base/file_util.h"
 #include "base/json/json_value_serializer.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
@@ skipping 20 matching lines @@
   std::string extension_id("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
   std::string version("1.0");
   FilePath src = temp.path().AppendASCII(extension_id);
   ASSERT_TRUE(file_util::CreateDirectory(src));
 
   // Create a extensions tree.
   FilePath all_extensions = temp.path().AppendASCII("extensions");
   ASSERT_TRUE(file_util::CreateDirectory(all_extensions));
 
   // Install in empty directory. Should create parent directories as needed.
-  FilePath version_1 = extension_file_util::InstallExtension(src,
-                                                             extension_id,
-                                                             version,
-                                                             all_extensions);
+  FilePath version_1 = extension_file_util::InstallExtension(
+      src,

[jeremy, 2012/02/12 09:40:28]

IMHO this should be indented 4 from the start of the function call column e.g.
in relation to extension_file_util , also below.

+      extension_id,
+      version,
+      all_extensions,
+      extension_file_util::DELETE_SOURCE_YES);
   ASSERT_EQ(version_1.value(),
             all_extensions.AppendASCII(extension_id).AppendASCII("1.0_0")
                 .value());
   ASSERT_TRUE(file_util::DirectoryExists(version_1));
 
   // Should have moved the source.
   ASSERT_FALSE(file_util::DirectoryExists(src));
 
   // Install again. Should create a new one with different name.
   ASSERT_TRUE(file_util::CreateDirectory(src));
-  FilePath version_2 = extension_file_util::InstallExtension(src,
-                                                             extension_id,
-                                                             version,
-                                                             all_extensions);
+  FilePath version_2 = extension_file_util::InstallExtension(
+      src,
+      extension_id,
+      version,
+      all_extensions,
+      extension_file_util::DELETE_SOURCE_YES);
   ASSERT_EQ(version_2.value(),
             all_extensions.AppendASCII(extension_id).AppendASCII("1.0_1")
                 .value());
   ASSERT_TRUE(file_util::DirectoryExists(version_2));
 
   // Collect garbage. Should remove first one.
   std::map<std::string, FilePath> extension_paths;
   extension_paths[extension_id] =
       FilePath().AppendASCII(extension_id).Append(version_2.BaseName());
   extension_file_util::GarbageCollectExtensions(all_extensions,
@@ skipping 288 matching lines @@
   EXPECT_FALSE(extension_file_util::ValidateExtension(extension, &error));
   EXPECT_EQ(l10n_util::GetStringFUTF8(
       IDS_EXTENSION_LOAD_BACKGROUND_SCRIPT_FAILED,
       ASCIIToUTF16("http://google.com/foo.js")),
            error);
 }
 
 // TODO(aa): More tests as motivation allows. Maybe steal some from
 // ExtensionService? Many of them could probably be tested here without the
 // MessageLoop shenanigans.