PPAPI: Proxy VarArrayBuffer for out-of-process.

ppapi/proxy/serialized_var.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/serialized_var.h"
 
 #include "base/logging.h"
+#include "base/memory/ref_counted.h"
 #include "ipc/ipc_message_utils.h"
 #include "ppapi/proxy/dispatcher.h"
 #include "ppapi/proxy/interface_proxy.h"
 #include "ppapi/proxy/ppapi_param_traits.h"
 #include "ppapi/proxy/var_serialization_rules.h"
+#include "ppapi/shared_impl/ppapi_globals.h"
 #include "ppapi/shared_impl/var.h"
 
 namespace ppapi {
 namespace proxy {
 
 // SerializedVar::Inner --------------------------------------------------------
 
 SerializedVar::Inner::Inner()
     : serialization_rules_(NULL),
       var_(PP_MakeUndefined()),
@@ skipping 86 matching lines @@
     case PP_VARTYPE_STRING: {
       // TODO(brettw) in the case of an invalid string ID, it would be nice
       // to send something to the other side such that a 0 ID would be
       // generated there. Then the function implementing the interface can
       // handle the invalid string as if it was in process rather than seeing
       // what looks like a valid empty string.
       StringVar* string_var = StringVar::FromPPVar(var_);
       m->WriteString(string_var ? *string_var->ptr() : std::string());
       break;
     }
-    case PP_VARTYPE_ARRAY_BUFFER:
-      // TODO(dmichael): Proxy ArrayBuffer.
-      NOTIMPLEMENTED();
+    case PP_VARTYPE_ARRAY_BUFFER: {
+      // TODO(dmichael) in the case of an invalid var ID, it would be nice
+      // to send something to the other side such that a 0 ID would be
+      // generated there. Then the function implementing the interface can
+      // handle the invalid string as if it was in process rather than seeing
+      // what looks like a valid empty ArraryBuffer

[brettw, 2012/02/09 19:23:22]

Can you also put a TODO in here for unmapping if it wasn't already mapped?

+      ArrayBufferVar* buffer_var = ArrayBufferVar::FromPPVar(var_);
+      if (buffer_var) {
+        m->WriteData(static_cast<const char*>(buffer_var->Map()),
+                     buffer_var->ByteLength());
+      } else {
+        m->WriteData(NULL, 0);
+      }
       break;
+    }
     case PP_VARTYPE_OBJECT:
       m->WriteInt64(var_.value.as_id);
       break;
     case PP_VARTYPE_ARRAY:
     case PP_VARTYPE_DICTIONARY:
       // TODO(brettw) when these are supported, implement this.
       NOTIMPLEMENTED();
       break;
   }
 }
@@ skipping 36 matching lines @@
       break;
     case PP_VARTYPE_DOUBLE:
       success = IPC::ParamTraits<double>::Read(m, iter, &var_.value.as_double);
       break;
     case PP_VARTYPE_STRING: {
       std::string string_from_ipc;
       success = m->ReadString(iter, &string_from_ipc);
       var_ = StringVar::SwapValidatedUTF8StringIntoPPVar(&string_from_ipc);
       break;
     }
+    case PP_VARTYPE_ARRAY_BUFFER: {
+      int length = 0;
+      const char* message_bytes = NULL;
+      success = m->ReadData(iter, &message_bytes, &length);
+      if (success) {
+        var_ = PpapiGlobals::Get()->GetVarTracker()->MakeArrayBufferPPVar(
+            length, message_bytes);
+      }
+      break;
+    }
     case PP_VARTYPE_OBJECT:
       success = m->ReadInt64(iter, &var_.value.as_id);
       break;
     case PP_VARTYPE_ARRAY:
     case PP_VARTYPE_DICTIONARY:
       // TODO(brettw) when these types are supported, implement this.
       NOTIMPLEMENTED();
       break;
     default:
       // Leave success as false.
@@ skipping 299 matching lines @@
   inner_->ForceSetVarValueForTest(StringVar::StringToPPVar(str));
 }
 
 SerializedVarTestReader::SerializedVarTestReader(const SerializedVar& var)
     : SerializedVar(var) {
 }
 
 }  // namespace proxy
 }  // namespace ppapi