src/ia32/builtins-ia32.cc - Issue 9373028: Initial support for count-based profiling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/builtins-ia32.cc

Issue 9373028: Initial support for count-based profiling (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/builtins-ia32.cc

diff --git a/src/ia32/builtins-ia32.cc b/src/ia32/builtins-ia32.cc

index efa3456d8e0698de66e0e5d58eddd3452ca2d62e..56b8f2f2931d78745643d62ad6452eff154edbe3 100644

--- a/src/ia32/builtins-ia32.cc

+++ b/src/ia32/builtins-ia32.cc

@@ -1659,8 +1659,9 @@ void Builtins::Generate_OnStackReplacement(MacroAssembler* masm) {

__ j(not_equal, &skip, Label::kNear);

__ ret(0);

- // If we decide not to perform on-stack replacement we perform a

- // stack guard check to enable interrupts.

+ // Insert a stack guard check so that if we decide not to perform

+ // on-stack replacement right away, the function calling this stub can

+ // still be interrupted.

__ bind(&stack_check);

Label ok;

ExternalReference stack_limit =

« no previous file with comments | « src/full-codegen.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »