Initial support for count-based profiling

src/ia32/deoptimizer-ia32.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 210 matching lines @@
   // ok: ...
   //
   // We will patch away the branch so the code is:
   //
   //     cmp esp, <limit>  ;; Not changed
   //     nop
   //     nop
   //     call <on-stack replacment>
   //     test eax, <loop nesting depth>
   // ok:
-  ASSERT(*(call_target_address - 3) == 0x73 &&  // jae
-         *(call_target_address - 2) == 0x07 &&  // offset
-         *(call_target_address - 1) == 0xe8);   // call
+
+  if (FLAG_count_based_interrupts) {
+    ASSERT(*(call_target_address - 3) == 0x79);  // jns
+    ASSERT(*(call_target_address - 2) == 0x11);  // offset

[Vyacheslav Egorov (Chromium), 2012/02/14 12:52:47]

Please name magical constants. they are duplicated in the code.

[Jakob Kummerow, 2012/02/14 13:54:45]

Done.

+  } else {
+    ASSERT(*(call_target_address - 3) == 0x73);  // jae
+    ASSERT(*(call_target_address - 2) == 0x07);  // offset
+  }
+  ASSERT(*(call_target_address - 1) == 0xe8);    // call
   *(call_target_address - 3) = 0x66;  // 2 byte nop part 1
   *(call_target_address - 2) = 0x90;  // 2 byte nop part 2
   Assembler::set_target_address_at(call_target_address,
                                    replacement_code->entry());
 
   unoptimized_code->GetHeap()->incremental_marking()->RecordCodeTargetPatch(
       unoptimized_code, call_target_address, replacement_code);
 }
 
 
 void Deoptimizer::RevertStackCheckCodeAt(Code* unoptimized_code,
                                          Address pc_after,
                                          Code* check_code,
                                          Code* replacement_code) {
   Address call_target_address = pc_after - kIntSize;
   ASSERT(replacement_code->entry() ==
          Assembler::target_address_at(call_target_address));
+
   // Replace the nops from patching (Deoptimizer::PatchStackCheckCode) to
   // restore the conditional branch.
   ASSERT(*(call_target_address - 3) == 0x66 &&  // 2 byte nop part 1
          *(call_target_address - 2) == 0x90 &&  // 2 byte nop part 2
          *(call_target_address - 1) == 0xe8);   // call
-  *(call_target_address - 3) = 0x73;  // jae
-  *(call_target_address - 2) = 0x07;  // offset
+  if (FLAG_count_based_interrupts) {
+    *(call_target_address - 3) = 0x79;  // jns
+    *(call_target_address - 2) = 0x11;  // offset
+  } else {
+    *(call_target_address - 3) = 0x73;  // jae
+    *(call_target_address - 2) = 0x07;  // offset
+  }
   Assembler::set_target_address_at(call_target_address,
                                    check_code->entry());
 
   check_code->GetHeap()->incremental_marking()->RecordCodeTargetPatch(
       unoptimized_code, call_target_address, check_code);
 }
 
 
 static int LookupBailoutId(DeoptimizationInputData* data, unsigned ast_id) {
   ByteArray* translations = data->TranslationByteArray();
@@ skipping 649 matching lines @@
   }
   __ bind(&done);
 }
 
 #undef __
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32