Issue 9373022: Streamline throwing in the C entry stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9373022: Streamline throwing in the C entry stub. (Closed)

Created:
8 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
8 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Google), fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Streamline throwing in the C entry stub. Remove a gratuitous level of indirection in favor of direct calls to the macro assembler, and eliminate some duplicated code for the uncatchable case. R=fschneider@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10671

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -148 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	3 chunks	+19 lines, -16 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	2 chunks	+2 lines, -18 lines	0 comments	Download
M	src/code-stubs.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	4 chunks	+15 lines, -15 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	2 chunks	+2 lines, -15 lines	0 comments	Download
M	src/macro-assembler.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	3 chunks	+19 lines, -16 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	2 chunks	+2 lines, -18 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	4 chunks	+16 lines, -16 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	2 chunks	+2 lines, -16 lines	0 comments	Download

Total messages: 3 (0 generated)

Kevin Millikin (Chromium)

Slava, could you take a quick look at this?

8 years, 10 months ago (2012-02-10 08:16:46 UTC) #2

lgtm