libavformat/utils.c - Issue 9373002: Fix valgrind and asan memory leaks and crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: libavformat/utils.c

Issue 9373002: Fix valgrind and asan memory leaks and crashes. (Closed) Base URL: ssh://gerrit.chromium.org:29418/chromium/third_party/ffmpeg.git@master

Patch Set: Make vp3 fix an ignore. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: libavformat/utils.c

diff --git a/libavformat/utils.c b/libavformat/utils.c

index 71baf58d6003358991faa4ba38411039c85a316c..8833a0b477c2902fac38b442478b5cd965b03eac 100644

--- a/libavformat/utils.c

+++ b/libavformat/utils.c

@@ -595,8 +595,10 @@ int avformat_open_input(AVFormatContext **ps, const char *filename, AVInputForma

ff_id3v2_read(s, ID3v2_DEFAULT_MAGIC);

if (!(s->flags&AVFMT_FLAG_PRIV_OPT) && s->iformat->read_header)

- if ((ret = s->iformat->read_header(s)) < 0)

+ if ((ret = s->iformat->read_header(s)) < 0) {

+ s->iformat->read_close(s);

goto fail;

+ }

if (!(s->flags&AVFMT_FLAG_PRIV_OPT) && s->pb && !s->data_offset)

s->data_offset = avio_tell(s->pb);

« no previous file with comments | « libavformat/oggparsevorbis.c ('k') | no next file » | no next file with comments »