libavformat/oggparsetheora.c - Issue 9373002: Fix valgrind and asan memory leaks and crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: libavformat/oggparsetheora.c

Issue 9373002: Fix valgrind and asan memory leaks and crashes. (Closed) Base URL: ssh://gerrit.chromium.org:29418/chromium/third_party/ffmpeg.git@master

Patch Set: Make vp3 fix an ignore. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: libavformat/oggparsetheora.c

diff --git a/libavformat/oggparsetheora.c b/libavformat/oggparsetheora.c

index 993db3ee558b0c1c08fa634c0fc5acb714292e41..9779a1602bcb33c688f253a41f7bcfda43b839e3 100644

--- a/libavformat/oggparsetheora.c

+++ b/libavformat/oggparsetheora.c

@@ -130,6 +130,7 @@ theora_gptopts(AVFormatContext *ctx, int idx, uint64_t gp, int64_t *dts)

struct ogg *ogg = ctx->priv_data;

struct ogg_stream *os = ogg->streams + idx;

struct theora_params *thp = os->private;

+ if (!thp) return NULL;

uint64_t iframe = gp >> thp->gpshift;

uint64_t pframe = gp & thp->gpmask;

« no previous file with comments | « libavformat/oggdec.c ('k') | libavformat/oggparsevorbis.c » ('j') | no next file with comments »