Fix valgrind and asan memory leaks and crashes.

libavformat/utils.c

 /*
  * various utility functions for use within FFmpeg
  * Copyright (c) 2000, 2001, 2002 Fabrice Bellard
  *
  * This file is part of FFmpeg.
  *
  * FFmpeg is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
  * version 2.1 of the License, or (at your option) any later version.
@@ skipping 15 matching lines @@
 #include "internal.h"
 #include "libavcodec/internal.h"
 #include "libavcodec/raw.h"
 #include "libavcodec/bytestream.h"
 #include "libavutil/avassert.h"
 #include "libavutil/opt.h"
 #include "libavutil/dict.h"
 #include "libavutil/pixdesc.h"
 #include "metadata.h"
 #include "id3v2.h"
+#include "isom.h"
 #include "libavutil/avassert.h"
 #include "libavutil/avstring.h"
 #include "libavutil/mathematics.h"
 #include "libavutil/parseutils.h"
 #include "riff.h"
 #include "audiointerleave.h"
 #include "url.h"
 #include <sys/time.h>
 #include <time.h>
 #include <stdarg.h>
@@ skipping 2649 matching lines @@
         st = s->streams[i];
         if (st->parser) {
             av_parser_close(st->parser);
             av_free_packet(&st->cur_pkt);
         }
         av_dict_free(&st->metadata);
         av_freep(&st->index_entries);
         av_freep(&st->codec->extradata);
         av_freep(&st->codec->subtitle_header);
         av_freep(&st->codec);
+
+        MOVStreamContext *sc = st->priv_data;
+        if (sc) {
+            if (sc->keyframes)
+                av_freep(&sc->keyframes);

[rbultje1, 2012/02/08 23:51:56]

av_freep() does the if() internally, so no need for the if() here.

[DaleCurtis, 2012/02/09 04:03:28]

Done.

+            if (sc->stsc_data)
+                av_freep(&sc->stsc_data);
+            if (sc->sample_sizes)
+                av_freep(&sc->sample_sizes);
+            if (sc->chunk_offsets)
+                av_freep(&sc->chunk_offsets);
+            if (sc->stts_data)
+                av_freep(&sc->stts_data);
+            if (sc->drefs)
+                av_freep(&sc->drefs);
+        }
+
         av_freep(&st->priv_data);
         av_freep(&st->info);
         av_freep(&st);
     }
     for(i=s->nb_programs-1; i>=0; i--) {
         av_dict_free(&s->programs[i]->metadata);
         av_freep(&s->programs[i]->stream_index);
         av_freep(&s->programs[i]);
     }
     av_freep(&s->programs);
@@ skipping 1472 matching lines @@
 }
 
 const struct AVCodecTag *avformat_get_riff_video_tags(void)
 {
     return ff_codec_bmp_tags;
 }
 const struct AVCodecTag *avformat_get_riff_audio_tags(void)
 {
     return ff_codec_wav_tags;
 }