Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 9373001: net: Rename FileStream::Open/Close with OpenSync/CloseSync. (Closed)

Created:
8 years, 10 months ago by satorux1
Modified:
8 years, 10 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, cbentzel+watch_chromium.org, dcheng, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

net: Rename FileStream::Open/Close with OpenSync/CloseSync. This is in preparation for implementing async versions of Open() and Close(). The existing clients are changed to use OpenSync/CloseSync. No logic is changed. The original patch was reverted as it broke linux_chromeos build. This patch includes fixes for the build. TEST=git try -r 121075 --bot=win,linux,mac,linux_chromeos,linux_chromeos_gtk,win_aura to confirm everything is built as before. BUG=72001 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121202

Patch Set 1 #

Patch Set 2 : fix linux_chromeos #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -89 lines) Patch
M chrome/browser/bookmarks/bookmark_html_writer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/imageburner/burn_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/bloom_filter.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sessions/session_backend.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/zip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/zip_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/base_file.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/base_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/drag_download_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/redirect_to_file_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/web_drag_source_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M net/base/file_stream.h View 1 chunk +12 lines, -8 lines 0 comments Download
M net/base/file_stream_posix.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/file_stream_unittest.cc View 32 chunks +32 lines, -32 lines 0 comments Download
M net/base/file_stream_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/mock_file_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mock_file_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/upload_data.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/base/upload_data_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/dump_files.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_file_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/blob/blob_url_request_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_url_request_job.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
satorux1
8 years, 10 months ago (2012-02-08 23:37:17 UTC) #1
satorux1
Sorry to bother you guys again. The original patch was reverted as it broke linux_chromeos ...
8 years, 10 months ago (2012-02-08 23:40:28 UTC) #2
tony
rs LGTM
8 years, 10 months ago (2012-02-08 23:41:01 UTC) #3
jam
lgtm
8 years, 10 months ago (2012-02-09 00:19:30 UTC) #4
willchan no longer on Chromium
8 years, 10 months ago (2012-02-09 02:09:01 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698