Make VideoCapture_Dev backward compatible.

Make VideoCapture_Dev backward compatible.

BUG=None
TEST=ppapi/examples/video_capture works.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123848

[yzshen1, 2012-02-22 22:44:09]

Hi, Brett and Trung.

Please take a look:

Brett: owner stamp.
Trung: everything.

Thanks!

[brettw, 2012-02-23 18:02:21]

Rubber stamp LGTM (didn't look).

[viettrungluu, 2012-02-27 19:29:19]

LGTM w/nits.

http://codereview.chromium.org/9372122/diff/1/ppapi/cpp/dev/video_capture_dev.cc
File ppapi/cpp/dev/video_capture_dev.cc (right):

http://codereview.chromium.org/9372122/diff/1/ppapi/cpp/dev/video_capture_dev...
ppapi/cpp/dev/video_capture_dev.cc:126: }
Nit: Maybe you should return something other than PP_ERROR_NOINTERFACE in the
case that device_ref isn't null? Maybe PP_ERROR_NOTSUPPORTED?

(In which case, the "else" is unnecessary.)

http://codereview.chromium.org/9372122/diff/1/ppapi/cpp/dev/video_capture_dev...
ppapi/cpp/dev/video_capture_dev.cc:136: } else if
(has_interface<PPB_VideoCapture_Dev_0_1>()) {
"else" unneeded.

http://codereview.chromium.org/9372122/diff/1/ppapi/cpp/dev/video_capture_dev...
ppapi/cpp/dev/video_capture_dev.cc:148: } else if
(has_interface<PPB_VideoCapture_Dev_0_1>()) {
"

http://codereview.chromium.org/9372122/diff/1/ppapi/cpp/dev/video_capture_dev...
ppapi/cpp/dev/video_capture_dev.cc:160: } else if
(has_interface<PPB_VideoCapture_Dev_0_1>()) {
"

[yzshen1, 2012-02-27 19:38:07]

Thanks, Trung.

http://codereview.chromium.org/9372122/diff/1/ppapi/cpp/dev/video_capture_dev.cc
File ppapi/cpp/dev/video_capture_dev.cc (right):

http://codereview.chromium.org/9372122/diff/1/ppapi/cpp/dev/video_capture_dev...
ppapi/cpp/dev/video_capture_dev.cc:126: }
On 2012/02/27 19:29:19, viettrungluu wrote:
> Nit: Maybe you should return something other than PP_ERROR_NOINTERFACE in the
> case that device_ref isn't null? Maybe PP_ERROR_NOTSUPPORTED?
> 
> (In which case, the "else" is unnecessary.)

Done.

http://codereview.chromium.org/9372122/diff/1/ppapi/cpp/dev/video_capture_dev...
ppapi/cpp/dev/video_capture_dev.cc:136: } else if
(has_interface<PPB_VideoCapture_Dev_0_1>()) {
On 2012/02/27 19:29:19, viettrungluu wrote:
> "else" unneeded.

Done.

http://codereview.chromium.org/9372122/diff/1/ppapi/cpp/dev/video_capture_dev...
ppapi/cpp/dev/video_capture_dev.cc:148: } else if
(has_interface<PPB_VideoCapture_Dev_0_1>()) {
On 2012/02/27 19:29:19, viettrungluu wrote:
> "

Done.

http://codereview.chromium.org/9372122/diff/1/ppapi/cpp/dev/video_capture_dev...
ppapi/cpp/dev/video_capture_dev.cc:160: } else if
(has_interface<PPB_VideoCapture_Dev_0_1>()) {
On 2012/02/27 19:29:19, viettrungluu wrote:
> "

Done.