Issue 9372111: History page: Removing ugly css hack (negative margins).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9372111: History page: Removing ugly css hack (negative margins). (Closed)

Created:
8 years, 10 months ago by dpapad

Modified:
8 years, 10 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, Patrick Dubroy, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

History page: Removing ugly css hack (negative margins). BUG=NONE TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123195

Patch Set 1 #

Patch Set 2 : Addressing comments, fixing minor issues #

Patch Set 3 : Rebasing #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -11 lines)			Patch
	M	chrome/browser/resources/history.css	View	1	2 chunks	+11 lines, -2 lines	0 comments	Download
	M	chrome/browser/resources/history.html	View	1	1 chunk	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpapad@chromium.org/9372111/3001

8 years, 10 months ago (2012-02-23 01:28:28 UTC) #4

commit-bot: I haz the power

8 years, 10 months ago (2012-02-23 04:47:57 UTC) #5

Try job failure for 9372111-3001 (previous was lost) (retry) on win_rel for step
"ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages