Issue 9372106: Make HashMap a template class to specify the allocation policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9372106: Make HashMap a template class to specify the allocation policy. (Closed)

Created:
8 years, 10 months ago by fschneider

Modified:
8 years, 10 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Make HashMap a template class to specify the allocation policy. The old HashMap class had an explicit member to determine the allocation policy. The template version matches the approach used already for lists. Cleanup some include dependencies and unnecessary forward declarations. Cleanup some dead code from isolate.h and replace some HEAP macros with GetHeap(). Committed: https://code.google.com/p/v8/source/detail?r=10806

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+220 lines, -311 lines)			Patch
M	src/SConscript	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	src/ast.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/bootstrapper.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	src/compilation-cache.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/cpu-profiler.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/hashmap.h	View	4 chunks	+197 lines, -20 lines	0 comments	Download
D	src/hashmap.cc	View	1 chunk	+0 lines, -224 lines	0 comments	Download
M	src/isolate.h	View	3 chunks	+1 line, -18 lines	1 comment	Download
M	src/log.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/preparser.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/scopes.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/scopes.cc	View	4 chunks	+3 lines, -23 lines	0 comments	Download
M	src/zone.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

8 years, 10 months ago (2012-02-23 08:01:25 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/9372106/diff/1/src/isolate.h
File src/isolate.h (left):

https://chromiumcodereview.appspot.com/9372106/diff/1/src/isolate.h#oldcode287
src/isolate.h:287: V(bool, is_virtual_frame_in_spilled_scope, false)            
               \
This is probably unrelated code, but still dead code, I think, correct?

Expand Messages | Collapse Messages