Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 9372105: Speedup dominators construction in heap snapshot. (Closed)

Created:
8 years, 10 months ago by alexeif
Modified:
8 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Speedup dominators construction in heap snapshot. It is achieved by: 1. skipping entries those dominators have already reached root. 2. processing only entries those retainers have changed their dominators and skipping other entries. 3. removing extra memory indirection by making the dominators array contain entry indices instead of entries themselves. The dominators building time has dropped from ~4000 ms to ~200 ms on gmail.com heap snapshot. BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=10799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -29 lines) Patch
M src/profile-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.cc View 2 chunks +48 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
alexeif
Mike, could you please take a look. Thanks!
8 years, 10 months ago (2012-02-22 16:24:46 UTC) #1
mnaganov (inactive)
8 years, 10 months ago (2012-02-22 22:52:37 UTC) #2
On 2012/02/22 16:24:46, alexeif wrote:
> Mike, could you please take a look.
> 
> Thanks!

Awesome!

LGTM, I'll submit this.

Powered by Google App Engine
This is Rietveld 408576698