Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9372099: Allow building OS X 10.7 binaries. (Closed)

Created:
8 years, 10 months ago by Alexander Potapenko
Modified:
8 years, 10 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews
Visibility:
Public.

Description

Allow building OS X 10.7 binaries. Roll valgrind-variant r136 for OS X 10.7 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123030

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2811 lines, -2 lines) Patch
M README.chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
A binaries/mac_10.7/bin/valgrind View Binary file 0 comments Download
A binaries/mac_10.7/bin/valgrind-listener View Binary file 0 comments Download
A binaries/mac_10.7/bin/vgdb View Binary file 0 comments Download
A binaries/mac_10.7/lib/valgrind/32bit-core.xml View 1 chunk +65 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/32bit-core-valgrind-s1.xml View 1 chunk +65 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/32bit-core-valgrind-s2.xml View 1 chunk +65 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/32bit-linux.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/32bit-linux-valgrind-s1.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/32bit-linux-valgrind-s2.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/32bit-sse.xml View 1 chunk +52 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/32bit-sse-valgrind-s1.xml View 1 chunk +52 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/32bit-sse-valgrind-s2.xml View 1 chunk +52 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/64bit-core.xml View 1 chunk +73 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/64bit-core-valgrind-s1.xml View 1 chunk +73 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/64bit-core-valgrind-s2.xml View 1 chunk +73 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/64bit-linux.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/64bit-linux-valgrind-s1.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/64bit-linux-valgrind-s2.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/64bit-sse.xml View 1 chunk +60 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/64bit-sse-valgrind-s1.xml View 1 chunk +60 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/64bit-sse-valgrind-s2.xml View 1 chunk +60 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/amd64-coresse-valgrind.xml View 1 chunk +19 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/amd64-linux-valgrind.xml View 1 chunk +23 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/arm-core.xml View 1 chunk +31 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/arm-core-valgrind-s1.xml View 1 chunk +31 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/arm-core-valgrind-s2.xml View 1 chunk +31 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/arm-vfpv3.xml View 1 chunk +44 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/arm-vfpv3-valgrind-s1.xml View 1 chunk +44 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/arm-vfpv3-valgrind-s2.xml View 1 chunk +44 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/arm-with-vfpv3.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/arm-with-vfpv3-valgrind.xml View 1 chunk +16 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/default.supp View 1 chunk +855 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/i386-coresse-valgrind.xml View 1 chunk +19 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/i386-linux-valgrind.xml View 1 chunk +23 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/memcheck-amd64-darwin View Binary file 0 comments Download
A binaries/mac_10.7/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Info.plist View 1 chunk +20 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/memcheck-amd64-darwin.dSYM/Contents/Resources/DWARF/memcheck-amd64-darwin View Binary file 0 comments Download
A binaries/mac_10.7/lib/valgrind/memcheck-x86-darwin View Binary file 0 comments Download
A binaries/mac_10.7/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Info.plist View 1 chunk +20 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/memcheck-x86-darwin.dSYM/Contents/Resources/DWARF/memcheck-x86-darwin View Binary file 0 comments Download
A binaries/mac_10.7/lib/valgrind/power-altivec.xml View 1 chunk +57 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power-altivec-valgrind-s1.xml View 1 chunk +57 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power-altivec-valgrind-s2.xml View 1 chunk +57 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power-core.xml View 1 chunk +49 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power-fpu.xml View 1 chunk +44 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power-fpu-valgrind-s1.xml View 1 chunk +44 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power-fpu-valgrind-s2.xml View 1 chunk +44 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power-linux.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power-linux-valgrind-s1.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power-linux-valgrind-s2.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power64-core.xml View 1 chunk +49 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power64-core-valgrind-s1.xml View 1 chunk +49 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power64-core-valgrind-s2.xml View 1 chunk +49 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power64-linux.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power64-linux-valgrind-s1.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/power64-linux-valgrind-s2.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/powerpc-altivec32l.xml View 1 chunk +19 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/powerpc-altivec32l-valgrind.xml View 1 chunk +27 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/powerpc-altivec64l.xml View 1 chunk +19 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/powerpc-altivec64l-valgrind.xml View 1 chunk +27 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/vgpreload_core-amd64-darwin.so.dSYM/Contents/Info.plist View 1 chunk +20 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/vgpreload_core-x86-darwin.so.dSYM/Contents/Info.plist View 1 chunk +20 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/vgpreload_memcheck-amd64-darwin.so.dSYM/Contents/Info.plist View 1 chunk +20 lines, -0 lines 0 comments Download
A binaries/mac_10.7/lib/valgrind/vgpreload_memcheck-x86-darwin.so.dSYM/Contents/Info.plist View 1 chunk +20 lines, -0 lines 0 comments Download
M scripts/build-memcheck-for-chromium.sh View 1 chunk +1 line, -1 line 0 comments Download
M scripts/common.sh View 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexander Potapenko
PTAL
8 years, 10 months ago (2012-02-22 12:56:11 UTC) #1
Timur Iskhodzhanov
LGTM with one nit and one possible reason to have a follow-up CL https://chromiumcodereview.appspot.com/9372099/diff/1/README.chromium File ...
8 years, 10 months ago (2012-02-22 13:08:20 UTC) #2
Alexander Potapenko
8 years, 10 months ago (2012-02-22 13:11:54 UTC) #3 
> https://chromiumcodereview.appspot.com/9372099/diff/1/README.chromium#newcode5
> README.chromium:5: Memcheck version on Mac 10.5 (valgrind-variant): 135
> any reason to not update 10.5/10.6 ?
The diff between r135 and r136 is 10.7 specific, so we just don't need to.

>https://chromiumcodereview.appspot.com/9372099/diff/1/README.chromium#newcode7
> README.chromium:7: Memcheck version on Mac 10.6 (valgrind-variant): 136
> 10.7 ?
Fixed, thanks.

Powered by Google App Engine
This is Rietveld 408576698