Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: chrome/browser/extensions/extension_global_error.cc

Issue 9372091: Polished on side-loaded extension install alert. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Corrections Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/chromium_strings.grd ('K') | « chrome/app/google_chrome_strings.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_global_error.cc
diff --git a/chrome/browser/extensions/extension_global_error.cc b/chrome/browser/extensions/extension_global_error.cc
index 173964a3d246546719c332989d83c7d5a94d7764..c8e88a3a39e4d49a8a318b131876d40c934be913 100644
--- a/chrome/browser/extensions/extension_global_error.cc
+++ b/chrome/browser/extensions/extension_global_error.cc
@@ -86,14 +86,17 @@ string16 ExtensionGlobalError::GenerateMessage() {
return GenerateMessageSection(external_extension_ids_.get(),
IDS_EXTENSION_ALERT_ITEM_EXTERNAL) +
GenerateMessageSection(blacklisted_extension_ids_.get(),
- IDS_EXTENSION_ALERT_ITEM_EXTERNAL) +
+ IDS_EXTENSION_ALERT_ITEM_BLACKLISTED) +
GenerateMessageSection(orphaned_extension_ids_.get(),
- IDS_EXTENSION_ALERT_ITEM_EXTERNAL);
+ IDS_EXTENSION_ALERT_ITEM_ORPHANED);
}
string16 ExtensionGlobalError::GetBubbleViewMessage() {
if (message_.empty()) {
message_ = GenerateMessage();
+ if (message_[message_.size()-1] == '\n') {
Aaron Boodman 2012/03/02 18:47:35 No curly brace needed for two-line if statements.
+ message_.resize(message_.size()-1);
+ }
}
return message_;
}
« chrome/app/chromium_strings.grd ('K') | « chrome/app/google_chrome_strings.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698