Add ninja Windows binaries.

Add ninja Windows binaries.

Built from https://github.com/sgraham/ninja/tree/deplist.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122940

[scottmg, 2012-02-22 01:03:44]

Random binaries built from my branch. gyp support currently needs the deplist
helper and there's one fix to core in that branch too.

If you feel up to it, probably would be nicer to build a version that's at least
from a branch in github.com/martine/... but NBD for me either way.

[Marc-Antoine Ruel (Google), 2012-02-22 01:06:15]

How large?

I wonder if the CQ will pass. My guess is that it won't. Can you try?

Too bad depot_tools is becoming so big.

Personally, I would have preferred to have ninja in third_party but I guess it's
too late now.

M-A

[scottmg, 2012-02-22 01:14:39]

Size: 208k + 80k.

Um, I tried:

gcl try u1t0

and got

gcl try: error: Please specify an access method.

So I tried gcl try u1t0 --use_svn

But it wants me to use --svn_repo still.

Since I screwed that up last time and managed to commit a raw diff somehow,
could you confirm what the command line should be for a try?



Why is it too late? Could we just leave a .bat + .sh in depot_tools to keep
something in the path, and move to third_party? I guess we can't find
Chromium from depot_tools is the problem?

On Tue, Feb 21, 2012 at 5:06 PM, <maruel@google.com> wrote:

> How large?
>
> I wonder if the CQ will pass. My guess is that it won't. Can you try?
>
> Too bad depot_tools is becoming so big.
>
> Personally, I would have preferred to have ninja in third_party but I
> guess it's
> too late now.
>
> M-A
>
>
https://chromiumcodereview.**appspot.com/9372088/<https://chromiumcodereview....
>

[M-A Ruel, 2012-02-22 01:23:33]

It's too late because the linux executable has already been committed.

there's no try server for depot_tools, the presubmit checks run the tests.
just try checking the cq bit, if it fails, which I expect, commit manually.
Le 21 févr. 2012 20:14, "Scott Graham" <scottmg@chromium.org> a écrit :

> Size: 208k + 80k.
>
> Um, I tried:
>
> gcl try u1t0
>
> and got
>
> gcl try: error: Please specify an access method.
>
> So I tried gcl try u1t0 --use_svn
>
> But it wants me to use --svn_repo still.
>
> Since I screwed that up last time and managed to commit a raw diff
> somehow, could you confirm what the command line should be for a try?
>
>
>
> Why is it too late? Could we just leave a .bat + .sh in depot_tools to
> keep something in the path, and move to third_party? I guess we can't find
> Chromium from depot_tools is the problem?
>
> On Tue, Feb 21, 2012 at 5:06 PM, <maruel@google.com> wrote:
>
>> How large?
>>
>> I wonder if the CQ will pass. My guess is that it won't. Can you try?
>>
>> Too bad depot_tools is becoming so big.
>>
>> Personally, I would have preferred to have ninja in third_party but I
>> guess it's
>> too late now.
>>
>> M-A
>>
>>
https://chromiumcodereview.**appspot.com/9372088/<https://chromiumcodereview....
>>
>
>

[commit-bot: I haz the power, 2012-02-22 01:23:58]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[M-A Ruel, 2012-02-22 01:25:16]

lgtm now from right address.
Le 21 févr. 2012 20:23, <commit-bot@chromium.org> a écrit :

> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See
http://www.chromium.org/**getting-involved/become-a-**committer<http://www.ch...
> Note that this has nothing to do with OWNERS files.
>
>
http://codereview.chromium.**org/9372088/<http://codereview.chromium.org/9372...
>

[commit-bot: I haz the power, 2012-02-22 01:26:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/9372088/1

[commit-bot: I haz the power, 2012-02-22 01:26:05]

Failed to request the patch to try. Please note that binary filesare still
unsupported at the moment, this is being worked on.

Thanks for your patience.

HTTP Error 302: Found

[scottmg, 2012-02-22 01:28:27]

302 Found! Yay!

Oh.

I'm going to take my life in my hands and try to commit from Windows.
Fingers crossed...

On Tue, Feb 21, 2012 at 5:26 PM, <commit-bot@chromium.org> wrote:

> Failed to request the patch to try. Please note that binary filesare still
> unsupported at the moment, this is being worked on.
>
> Thanks for your patience.
>
> HTTP Error 302: Found
>
>
http://codereview.chromium.**org/9372088/<http://codereview.chromium.org/9372...
>