Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 9372027: Revert 121236 - Support sharing of ContentMain and BrowserMain code with embedded use cases (try ... (Closed)

Created:
8 years, 10 months ago by Marshall
Modified:
8 years, 10 months ago
Reviewers:
Marshall
CC:
chromium-reviews, cbentzel+watch_chromium.org, amit, jam, joi+watch-content_chromium.org, robertshield, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 121236 - Support sharing of ContentMain and BrowserMain code with embedded use cases (try #2). Tests failing. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+562 lines, -927 lines) Patch
M chrome/app/chrome_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main.h View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/chrome_browser_main.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/base/chrome_test_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 2 chunks +1 line, -5 lines 0 comments Download
A + content/app/content_main.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/app/content_main.cc View 1 chunk +441 lines, -11 lines 0 comments Download
D content/app/content_main_runner.cc View 1 chunk +0 lines, -559 lines 0 comments Download
M content/browser/browser_main.cc View 1 chunk +87 lines, -10 lines 0 comments Download
M content/browser/browser_main_loop.h View 1 chunk +6 lines, -12 lines 0 comments Download
M content/browser/browser_main_loop.cc View 4 chunks +9 lines, -8 lines 0 comments Download
D content/browser/browser_main_runner.cc View 1 chunk +0 lines, -148 lines 0 comments Download
MM content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/content_app.gypi View 2 chunks +2 lines, -4 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
D content/public/app/content_main.h View 1 chunk +0 lines, -43 lines 0 comments Download
M content/public/app/content_main_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
D content/public/app/content_main_runner.h View 1 chunk +0 lines, -57 lines 0 comments Download
M content/public/browser/browser_main_parts.h View 2 chunks +0 lines, -6 lines 0 comments Download
D content/public/browser/browser_main_runner.h View 1 chunk +0 lines, -37 lines 0 comments Download
M content/shell/shell_browser_main.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/shell_browser_main.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/shell_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/shell_main_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/content_test_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Marshall
8 years, 10 months ago (2012-02-09 16:48:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698