Issue 9372021: Enable inlining for Math.min/max in more cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9372021: Enable inlining for Math.min/max in more cases. (Closed)

Created:
8 years, 10 months ago by Yang

Modified:
8 years, 10 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Enable inlining for Math.min/max in more cases. Committed: https://code.google.com/p/v8/source/detail?r=10755

Patch Set 1 #

Total comments: 4

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -23 lines)			Patch
	M	src/hydrogen.cc	View		1 chunk	+28 lines, -23 lines	4 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2012/02/09 13:24:12, Yang wrote: > PTAL. > > I should have done this long ...

8 years, 10 months ago (2012-02-20 11:37:20 UTC) #2

fschneider

LGTM. Please make sure that the new cases are covered by our unit tests and ...

8 years, 10 months ago (2012-02-20 12:18:39 UTC) #3

Yang

8 years, 10 months ago (2012-02-20 13:14:11 UTC) #4

I added additional tests to math-min-max.js to test mixed representations.

https://chromiumcodereview.appspot.com/9372021/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/9372021/diff/1/src/hydrogen.cc#newcode...
src/hydrogen.cc:5324: left, Representation::Double(), false, true);
On 2012/02/20 12:18:39, fschneider wrote:
> Please break like this and comment the boolean paramters:
> 
> HChange(left,
>         Representation::Double(),
>         false,
>         true);
> 

Done.

https://chromiumcodereview.appspot.com/9372021/diff/1/src/hydrogen.cc#newcode...
src/hydrogen.cc:5330: right, Representation::Double(), false, true);
On 2012/02/20 12:18:39, fschneider wrote:
> Also here: Short same-line comment for the boolean paramters.

Done.

Expand Messages | Collapse Messages