Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 9372018: Fix d8-os unit test to be skipped for isolates. (Closed)

Created:
8 years, 10 months ago by Michael Starzinger
Modified:
8 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix d8-os unit test to be skipped for isolates. This test sets the umask on a per-process basis and hence cannot be used in multi-threaded runs. R=yangguo@chromium.org TEST=mjsunit/d8-os Committed: https://code.google.com/p/v8/source/detail?r=10655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M test/mjsunit/d8-os.js View 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 10 months ago (2012-02-09 09:51:26 UTC) #1
Yang
8 years, 10 months ago (2012-02-09 09:52:11 UTC) #2
On 2012/02/09 09:51:26, Michael Starzinger wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698