Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 9372016: Simplify handler pushing. (Closed)

Created:
8 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
8 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Simplify handler pushing. Instead of using two separate bits to encode three possible values, use three values to encode the three possible values. R=svenpanne@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10654

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -119 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 3 chunks +8 lines, -17 lines 0 comments Download
M src/frames.h View 3 chunks +11 lines, -9 lines 0 comments Download
M src/frames.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/frames-inl.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/full-codegen.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 3 chunks +10 lines, -15 lines 0 comments Download
M src/isolate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/macro-assembler.h View 2 chunks +1 line, -15 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +9 lines, -17 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 3 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
8 years, 10 months ago (2012-02-09 08:57:30 UTC) #1
Sven Panne
8 years, 10 months ago (2012-02-09 09:16:07 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698