Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 9371015: Merge 106468 - Web Inspector: debugger reports wrong sources when paused in inline script on page... (Closed)

Created:
9 years ago by yurys
Modified:
9 years ago
Reviewers:
yurys
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 106468 - Web Inspector: debugger reports wrong sources when paused in inline script on page reload https://bugs.webkit.org/show_bug.cgi?id=77548 Source/WebCore: V8 returns treats each script source as ending with \n, now we take this into account when reporting script line count to the inspector front-end. Reviewed by Vsevolod Vlasov. Test: inspector/debugger/pause-in-inline-script.html * bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource): * bindings/v8/DebuggerScript.js: LayoutTests: Reviewed by Vsevolod Vlasov. * inspector/debugger/debugger-scripts-expected.txt: * inspector/debugger/pause-in-inline-script-expected.txt: Added. * inspector/debugger/pause-in-inline-script.html: Added. * platform/chromium/inspector/debugger/debugger-scripts-expected.txt: TBR=yurys@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=107228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M LayoutTests/inspector/debugger/debugger-scripts-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
A + LayoutTests/inspector/debugger/pause-in-inline-script.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/debugger/pause-in-inline-script-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/chromium/inspector/debugger/debugger-scripts-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/WebCore/bindings/js/ScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/bindings/v8/DebuggerScript.js View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
yurys
9 years ago (2012-02-09 13:46:29 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698