Issue 9371013: Cleaned up DescriptorArray::CopyInsert a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9371013: Cleaned up DescriptorArray::CopyInsert a bit. (Closed)

Created:
8 years, 10 months ago by Sven Panne

Modified:
8 years, 10 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cleaned up DescriptorArray::CopyInsert a bit. The point of this refactoring is to remove some copy 'n' paste from the code, preparing some upcoming changes related to CopyFrom and CALLBACKS with transitions. The index fiddling is tricky enough to warrant a separate refacoring-only CL... Committed: https://code.google.com/p/v8/source/detail?r=10656

Patch Set 1 #

Patch Set 2 : Cleaned up DescriptorArray::CopyInsert a bit. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -19 lines)			Patch
	M	src/objects.cc	View		2 chunks	+20 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages